Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Major Planning Permission example payload #194

Merged
merged 5 commits into from
Jul 3, 2024

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Jul 3, 2024

Relies on #192

Adds a Major Planning Permission example (non-London) plus a few related type adjustments/additions!

@jessicamcinchak jessicamcinchak changed the title feat: Major Planning Permission payload example feat: Major Planning Permission example payload Jul 3, 2024
@jessicamcinchak
Copy link
Member Author

@jessicamcinchak jessicamcinchak marked this pull request as ready for review July 3, 2024 09:57
@jessicamcinchak jessicamcinchak requested a review from a team July 3, 2024 09:57
@jessicamcinchak jessicamcinchak marked this pull request as draft July 3, 2024 11:14
@jessicamcinchak jessicamcinchak marked this pull request as ready for review July 3, 2024 13:36
@@ -245,7 +245,7 @@ export const priorApprovalBuildHomes: Schema = {
projectType: [
{
value: 'new.residential.dwelling',
description: 'Build new homes on a roof',
description: 'Build new homes',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot! 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I swear I copied this from content somewhere but it was a weird one lol 🏠

@jessicamcinchak jessicamcinchak merged commit 73845ee into main Jul 3, 2024
3 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/major-pp-example branch July 3, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants